#416 get_visitor_os() incorrectly identifies Ubuntu as Windows

Closed
opened 7 months ago by hristoast · 1 comments

The current method for guessing a user-agent doesn't properly identify some Linux-using visitors.

Something like Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0 falls through the current conditional, and it's likely that more do as well.

[The current method](https://git.modding-openmw.com/Modding-OpenMW.com/momw/src/commit/4152343315f34196725b6f6f6518d98072bea687/momw/momw/cfg.py#L95-L109) for guessing a user-agent doesn't properly identify some Linux-using visitors. Something like `Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0` falls through the current conditional, and it's likely that more do as well.
hristoast self-assigned this 7 months ago
hristoast added the
UX/Text
label 7 months ago
hristoast changed title from User-agent incorrectly identifies Ubuntu as Windows to get_visitor_os() incorrectly identifies Ubuntu as Windows 7 months ago
hristoast commented 5 months ago
Owner

Hopefully fixed by a4b7563ea1

Hopefully fixed by https://git.modding-openmw.com/Modding-OpenMW.com/momw/commit/a4b7563ea1f766ef66984eb5d16417e03f2f2bf9
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.